Node-restify Code Review

ISGroup SRL performed an automated Code Review (not a real Static Analysis, more a grep-on-steroid) of this NodeJS project in order to identify potential security vulnerabilities. We do not guarantee that all the findings are valid, and for sure there are plenty of false-positives and false-negatives (undetected issues) but it's free and your project could benefit from this security analisys. The following data is also available in JSON format!

Possible Security Issues

Issue	Description	Line	File
Express BodyParser Tempfile Creation Issue	POST Request to Express Body Parser 'bodyParser()' can create Temporary files and consume space.	47	test/fielded_text_parser.test.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	95	test/throttle.test.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	1970	test/server.test.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	1978	test/server.test.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	2016	test/server.test.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	37	test/upgrade.test.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	407	test/upgrade.test.js
Express BodyParser Tempfile Creation Issue	POST Request to Express Body Parser 'bodyParser()' can create Temporary files and consume space.	204	test/plugins.test.js
Express BodyParser Tempfile Creation Issue	POST Request to Express Body Parser 'bodyParser()' can create Temporary files and consume space.	265	test/plugins.test.js
Express BodyParser Tempfile Creation Issue	POST Request to Express Body Parser 'bodyParser()' can create Temporary files and consume space.	509	test/plugins.test.js
Express BodyParser Tempfile Creation Issue	POST Request to Express Body Parser 'bodyParser()' can create Temporary files and consume space.	564	test/plugins.test.js
Express BodyParser Tempfile Creation Issue	POST Request to Express Body Parser 'bodyParser()' can create Temporary files and consume space.	636	test/plugins.test.js
Server Side Injection(SSI) - setInterval()	User controlled data in 'setInterval()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	924	test/plugins.test.js
Express BodyParser Tempfile Creation Issue	POST Request to Express Body Parser 'bodyParser()' can create Temporary files and consume space.	977	test/plugins.test.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	1058	test/plugins.test.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	1103	test/plugins.test.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	1109	test/plugins.test.js
Key Hardcoded	A hardcoded key in plain text was identified.	1236	test/plugins.test.js
Key Hardcoded	A hardcoded key in plain text was identified.	1265	test/plugins.test.js
Key Hardcoded	A hardcoded key in plain text was identified.	1295	test/plugins.test.js
Key Hardcoded	A hardcoded key in plain text was identified.	1321	test/plugins.test.js
Key Hardcoded	A hardcoded key in plain text was identified.	1322	test/plugins.test.js
Express BodyParser Tempfile Creation Issue	POST Request to Express Body Parser 'bodyParser()' can create Temporary files and consume space.	378	examples/todoapp/lib/server.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	14	examples/dtrace/hello.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	131	examples/dtrace/demo.js
Server Side Injection(SSI) - setTimeout()	User controlled data in 'setTimeout()' can result in Server Side Injection (SSI) or Remote Code Execution (RCE).	93	lib/plugins/throttle.js
Weak Hash used - MD5	MD5 is a a weak hash which is known to have collision. Use a strong hashing function.	62	lib/plugins/full_response.js
Username Hardcoded	A hardcoded username in plain text was identified. Store it properly in a config file.	107	lib/plugins/authorization.js
Weak Hash used - MD5	MD5 is a a weak hash which is known to have collision. Use a strong hashing function.	85	lib/plugins/body_reader.js

Missing Security Features

Issue	Description
Missing Security Header - X-Frame-Options (XFO)	X-Frame-Options (XFO) header provides protection against Clickjacking attacks.
Missing Security Header - Content-Security-Policy (CSP)	Content Security Policy (CSP), a mechanism web applications can use to mitigate a broad class of content injection vulnerabilities, such as cross-site scripting (XSS). CSP Header was not found.
Missing Security Header - Strict-Transport-Security (HSTS)	Strict-Transport-Security (HSTS) header enforces secure (HTTP over SSL/TLS) connections to the server.
Missing 'httpOnly' in Cookie	JavaScript can access Cookies if they are not marked httpOnly.
Infromation Disclosure - X-Powered-By	Remove the X-Powered-By header to prevent information gathering.
Missing Security Header - X-Content-Type-Options	X-Content-Type-Options header prevents Internet Explorer and Google Chrome from MIME-sniffing a response away from the declared content-type.
Missing Security Header - X-Download-Options: noopen	X-Download-Options header set to noopen prevents IE users from directly opening and executing downloads in your site's context.
Missing Security Header - X-XSS-Protection:1	X-XSS-Protection header set to 1 enables the Cross-site scripting (XSS) filter built into most recent web browsers.
Missing Security Header - Public-Key-Pins (HPKP)	Public-Key-Pins (HPKP) ensures that certificate is Pinned.

Node.Security

Security Audit of Node-restify